Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a FieldContext to check for the existence of fields. #25

Open
wants to merge 5 commits into
base: drupal8
Choose a base branch
from

Conversation

zendoodles
Copy link
Contributor

A rough conversion of what we used on booth: https://github.com/palantirnet/booth/blob/develop/features/bootstrap/FeatureContext.php#L116

Obviously still needs some work, but maybe a good place to start the discussion.

@becw
Copy link
Member

becw commented Aug 4, 2016

We're trying to follow this field testing approach on AcademyHealth, too 💓 ... which is Drupal 8, so I think @patrickfweston and @Kbentham will be looking at this at some point.

@patrickfweston
Copy link
Contributor

@froboy
Copy link

froboy commented Aug 23, 2016

@mcarmichael21 and I have been working on some more tests on MCC. File fields don't have an "Add more" button, and checkboxes are also "multivalued" and need a test. Once those are solid we'll commit them here.

@zendoodles
Copy link
Contributor Author

zendoodles commented Dec 1, 2016

@froboy Could those additions be added in a follow-up so they do not block the merging of this PR? Or, if you've already got code for them, could you add it to this PR or as a PR against this PR?

cc @mcarmichael21

@froboy
Copy link

froboy commented Dec 2, 2016

@zendoodles both of those things are finished and in https://github.com/palantirnet/mcc/blob/develop/features/bootstrap/FeatureContext.php#L128. I'll try and get those merged into this soon. There's a bunch of differences between these two. Would you want to review the code there and either figure out how it should be merged or let me know how you'd like it merged. Specifically, the whole "multivalued" column in the test def seems like a pretty big change.

Andrea R Soper added 5 commits December 5, 2016 17:56
…) If your function/method is so long you can't see the end of it, it is probably too long. b) if you use a proper IDE, it highlights these things for you.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants