-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a FieldContext to check for the existence of fields. #25
base: drupal8
Are you sure you want to change the base?
Conversation
We're trying to follow this field testing approach on AcademyHealth, too 💓 ... which is Drupal 8, so I think @patrickfweston and @Kbentham will be looking at this at some point. |
Yep! I've implemented it in my latest PR 😸 : https://github.com/palantirnet/academyhealth/blob/fdd0b2a95a82c7681450bb12c4ba936de9c91cad/features/bootstrap/FeatureContext.php |
1069903
to
5f0dcf3
Compare
@mcarmichael21 and I have been working on some more tests on MCC. File fields don't have an "Add more" button, and checkboxes are also "multivalued" and need a test. Once those are solid we'll commit them here.
|
@froboy Could those additions be added in a follow-up so they do not block the merging of this PR? Or, if you've already got code for them, could you add it to this PR or as a PR against this PR? |
@zendoodles both of those things are finished and in https://github.com/palantirnet/mcc/blob/develop/features/bootstrap/FeatureContext.php#L128. |
…) If your function/method is so long you can't see the end of it, it is probably too long. b) if you use a proper IDE, it highlights these things for you.
5f0dcf3
to
5512ae1
Compare
A rough conversion of what we used on booth: https://github.com/palantirnet/booth/blob/develop/features/bootstrap/FeatureContext.php#L116
Obviously still needs some work, but maybe a good place to start the discussion.